search

tessel / t1-firmware

[UNMAINTAINED] Tessel 1 Firmware
Other
68 stars 20 forks source link

dgram (udp) catchup with runtime/pull/595 #104

Closed natevw closed 9 years ago

natevw commented 10 years ago

Should be ready, but does require coordinated release with https://github.com/tessel/runtime/pull/595https://github.com/tessel/runtime/pull/622.

tcr commented 10 years ago

lgtm. Travis is presenting errors for the header definitions: https://travis-ci.org/tessel/firmware/builds/38853484 Once fixed, I'll merge this.

Also just to check, the runtime version included in this PR should be master. We'll merge this first, then the runtime PR after, which then gets pulled into firmware by the merge tool.

tcr commented 10 years ago

Actually just one comment on the inline typedef.

tcr commented 10 years ago

And an API suggestion for tm_udp_receive in runtime that would require a change here. https://github.com/tessel/runtime/pull/595/files#diff-989f5e7cdba84de885a494044d101f0bR123

natevw commented 9 years ago

Ok, this should be caught up again unless you do want me to change up all those function signatures here and in runtime. (It might not be a bad idea since at some point we're going to want to actually handle errors and not having original length overwritten will be useful then.)

tcr commented 9 years ago

I'll make up for lost time and not ask that.

lgtm. Feel free to test / r+ this.

tm-rampart commented 9 years ago

Approved by @natevw. Running tests.

tm-rampart commented 9 years ago

Merge or tests failed.

tm-rampart commented 9 years ago

Approved by @tcr. Running tests.

tm-rampart commented 9 years ago

Merge or tests failed.

tcr commented 9 years ago

Merged in by #108.