tessel / t1-runtime

[UNMAINTAINED] Tessel 1 JavaScript runtime.
Other
117 stars 33 forks source link

added date.toUTCString #647

Closed nw closed 10 years ago

nw commented 10 years ago

This PR adds support for date.toUTCString().

I found out the hard way that a lot of date functions are not fully supported.

I'm a bit confused by timezones if and how they are implemented in lua/colony. It doesn't appear to be present. Maybe a more explicit end user command for initializing a tessel to a TZ would allow for these additional date functions to be flushed out. Again, my understanding currently is limited, but dates seem really important to me.

This patch gets me up and running with the npm/knox library for working with amazon s3.

tcr commented 10 years ago

This looks good to me. Thank you for digging into this and proposing a patch, we'll release a build today with this fix.

Our date and time strategy has been very poor. We currently have a few internal methods to synchronize clocks automatically using NTP, or otherwise use the time derived from when code is pushed, but neither is ideal. We recently implemented a slew of UDP improvements though that might help here. I've opened a relevant bug at https://github.com/tessel/runtime/issues/648

tm-rampart commented 10 years ago

Approved by @tcr. Running tests.