Buffer::fill with strings

tessel / t1-runtime

[UNMAINTAINED] Tessel 1 JavaScript runtime.

Other

117 stars 33 forks source link

Buffer::fill with strings #666

Closed LinusU closed 10 years ago

LinusU commented 10 years ago

This patch fixes #659.

All the current tests still passes and I've added some new ones as well.

LinusU commented 10 years ago

The build fails because node v0.10 dosen't support filling with a longer string than one character (see #659).

How do you guys want to handle this? I think that using the whole string is just an extra feature and won't break any code already in place. This will also be the stable behaviour as soon as 0.12 is out the door so I think that we should implement it right away....

johnnyman727 commented 10 years ago

@LinusU, I'd prefer if we could try to stick as closely to the released Node version as possible. Could you break this up into two PRs: one with fill for a single character and the other for an entire string? We'll merge the compatible one immediately and rebase/merge the latter when 0.12 is released.

LinusU commented 10 years ago

Closing in favour of #671 and #672.