Let the net/CC3K logic error rather than Agent "hang"

tessel / t1-runtime

[UNMAINTAINED] Tessel 1 JavaScript runtime.

Other

117 stars 33 forks source link

Let the net/CC3K logic error rather than Agent "hang" #675

Closed natevw closed 9 years ago

natevw commented 10 years ago

See https://github.com/tessel/runtime/issues/674#issuecomment-65664144.

Note that I haven't actually tested this on-device though, sorry — if that's convenient for someone feel free to test and merge otherwise I can try followup myself later.

natevw commented 10 years ago

To be clear, I'm not worried about this patch itself and am ± convinced it's the right thing to do. Whether it actually resolves #674 in a satisfactory fashion on device (generating a nice error which in the case of the OP test script should gracefully clear the timeout and just wait for earlier requests to finish) is what I am unsure of.

johnnyman727 commented 10 years ago

@natevw I tested this briefly with the test script from #674 and it didn't actually throw any errors on the device. There must be some other socket handling logic in there that's subtly trying to smooth out HTTP transactions.

natevw commented 10 years ago

Hmm, weird. I would have expected it to hit https://github.com/tessel/runtime/blob/fc1a971c870d5a55455b557bf31589cc75229a4f/src/colony/modules/net.js#L170 but like you say there could be more to the story.