search

tessel / t2-docs

Documentation for Tessel 2.
https://tessel.gitbooks.io/t2-docs/content/
Creative Commons Attribution Share Alike 4.0 International
28 stars 30 forks source link

Team DelSquared (RGSoC '18): Changed variable names #188

Closed arushi019 closed 6 years ago

arushi019 commented 6 years ago

cpol->polarity cpha->phase

tessel-bot commented 6 years ago

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @rwaldron (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

arushi019 commented 6 years ago

Hi! I have changed the name of commit as per the format suggested in the review. Kindly review @Frijol Issue: https://github.com/tessel/t2-docs/issues/80 [Team DelSquared RGSoC '18]

Frijol commented 6 years ago

Thanks, looks great!