search

tessel / t2-start

Tessel 2 start docs! Open for contributions.
http://tessel.io/start
35 stars 31 forks source link

typo fix for audio module `ended` event #134

Closed ducin closed 8 years ago

LinusU commented 8 years ago

Hmm end is used almost everywhere in Node, it would have been nice if tessel-av followed that. Anyhow, that's another discussion :)

LGTM

johnnyman727 commented 8 years ago

Hmm end is used almost everywhere in Node, it would have been nice if tessel-av followed that.

I agree - I think the solution would be to update tessel-av API to emit end.

Frijol commented 8 years ago

Just ran across this, should have been merged in July! @rwaldron can you confirm that this is still the correct syntax?

rwaldron commented 8 years ago

Hmm end is used almost everywhere in Node, it would have been nice if tessel-av followed that. I agree - I think the solution would be to update tessel-av API to emit end.

But it's not an "end" event in the sense that you're referring to, which is:

The 'end' event is emitted when there is no more data to be consumed from the stream.

(https://nodejs.org/api/stream.html#stream_event_end)

I chose "ended", because that's the event that's emitted for HTML audio when the sound's playback has ended. This naming was intentional to differentiate away from Node's "end" event.

rwaldron commented 8 years ago

@Frijol LGTM!