search

tessel / t2-start

Tessel 2 start docs! Open for contributions.
http://tessel.io/start
35 stars 31 forks source link

fall back to default OS monospace font for code blocks #159

Closed noopkat closed 7 years ago

noopkat commented 7 years ago

Hello lovely folks 👋

Was using the t2 start guide on Windows today and it looks beautiful 💅 A minor nit on the code blocks that I saw though. If you don't have Andale Mono installed on your computer, the font falls back to a serif font, which looks a bit weird. I added a monospace fallback to fix this in the stylesheet, hope that looks alright!

Before:

2017-03-13 17_05_04-tessel installation

After:

2017-03-13 17_05_30-tessel installation

I compiled this with Jekyll locally (where I took the 'after' screenshot) and it's displaying as expected.

Thanks for all the hard work on Tessel, goes without saying 💐

noopkat commented 7 years ago

doh! Looks like @flaki reported this #105 and also fixed it on his own fork. Feel free to merge or cherry-pick his over instead 😳

Frijol commented 7 years ago

I haven't heard from @flaki on https://github.com/flaki/t2-start/pull/1 so unless we hear from him shortly, let's go ahead and merge this one.

The only difference in the two forks is that his prefers Consolas (which looks more like Andale Mono) before defaulting to monospace. @noopkat would you be up for adding that in to yours as well?

noopkat commented 7 years ago

@Frijol Sorry for the delay! I just added Consolas to the fallback list. Thanks for the suggestion! Feel free to merge if this looks good.

flaki commented 7 years ago

LGTM on a Surface 4/Windows 10, merging!

Thank you Suz! 🤗