search

tesselode / kira

Library for expressive game audio.
https://crates.io/crates/kira
Apache License 2.0
866 stars 45 forks source link

Expose feature for shared stdxx on android #51

Closed NiklasEi closed 8 months ago

NiklasEi commented 1 year ago

The cpal feature seems to be needed to get bevy + kira to work on my android phone.

tesselode commented 1 year ago

Is this always going to be needed on Android, or only when using Kira with Bevy? If it's the former, can we just make this a platform-specific dependency?

NiklasEi commented 1 year ago

I don't think it's always needed, so I would follow the way cpal and bevy expose this via a feature flag.

From the cpal readme:

Oboe can either use a shared or static runtime. The static runtime is used by default, but activating the oboe-shared-stdcxx feature makes it use the shared runtime, which requires libc++_shared.so from the Android NDK to be present during execution.

NiklasEi commented 8 months ago

FYI: the same solution has been taken in rodio now: RustAudio/rodio#546

tesselode commented 8 months ago

ok fiiiine i'll merge it

(thank you for your investigation!)