search

tesselode / kira

Library for expressive game audio.
https://crates.io/crates/kira
Apache License 2.0
837 stars 42 forks source link

Rename set_pitch #9

Closed ghost closed 3 years ago

ghost commented 3 years ago

I believe the set_pitch function is incorrectly named. It just changes the playback rate of the music.

Changing the pitch without affecting playback rate would involve techniques like phase vocoding (as far as I know) or using a library like Rubber Band: https://en.wikipedia.org/wiki/Audio_time_stretching_and_pitch_scaling#Phase_vocoder https://breakfastquay.com/rubberband/

set_pitch should probably be called something like set_playback_rate.

tesselode commented 3 years ago

i will conduct some market research!

tesselode commented 3 years ago

you were right!