search

tessera-metrics / tessera

A dashboard front-end for graphite.
http://tessera-metrics.github.io/tessera/
Apache License 2.0
1.19k stars 81 forks source link

hide_zero_series should affect interactive legend as well #472

Closed kretes closed 9 years ago

kretes commented 9 years ago

Currently when I set hide_zero_series on standard time series to true - I do not get empty series on the chart, but when in interactive mode I look at the legend - it displays zero series still.

Zero series should be removed from this legend as well

aalpern commented 9 years ago

Agreed.

aalpern commented 9 years ago

Hmm - looks like it already tries to do that, with the exact same conditional in the legend as is in the chart rendering: https://github.com/urbanairship/tessera/blob/master/src/ts/charts/flot.ts#L208 and in my testing it's actually working fine.

aalpern commented 9 years ago

Ah - were you referring to the rollover data shown when hovering the mouse over the graph?

kretes commented 9 years ago

yes, I'm referring to rollover data, shown when in 'interactive mode'

aalpern commented 9 years ago

Got it - I misunderstood what you meant by "legend".

It's actually by design that all the series are shown in the mouseover, so that you can see all the series that were returned if you want to, while saving space on the static legend. I can see a strong case for going the other way with it too, though.

aalpern commented 9 years ago

Done