search

tesseract-ocr / tesstrain

Train Tesseract LSTM with make
Apache License 2.0
604 stars 178 forks source link

documentation: make help #257

Closed bertsky closed 3 years ago

bertsky commented 3 years ago

LGTM. Feel free to merge kba@bc19025 for minor inconsistent comments and regenerated make help in the README.

Sure! (I assume you produced that using your makefile parser, so consistency is enforced? I wonder what happened to FINETUNE_TYPE ...) @stweil?

stweil commented 3 years ago

FINETUNE_TYPE was added in commit 0f95a1a7cad11e62df7079fe10b64090ad6a8025, but only to README.md. Related changes for Makefile never got merged.

bertsky commented 3 years ago

FINETUNE_TYPE was added in commit 0f95a1a, but only to README.md. Related changes for Makefile never got merged.

Too bad! That's exactly what I was asking for in #255! It seems to have been removed in #134 simply because of the suffix in the model name. IMHO that's not a good reason to remove the option for additional training regimes completely. One could have just restored the model name (e.g. by only reverting c0dd8c9cbbd9611c0dccc4a20019bcc0334a9acf). But @Shreeshrii has also brought other ideas to the table (and removed again), e.g. 85b5ae8ef0a1e5388b81e9bc1af755081f420e92. Let's discuss that in #255!

bertsky commented 3 years ago

Feel free to merge kba@bc19025 for minor inconsistent comments and regenerated make help in the README.

@kba sry, you'll have to make a new PR now, this has already been merged.