search

tesseract-robotics / tesseract

Motion Planning Environment
http://tesseract-docs.rtfd.io
Other
257 stars 89 forks source link

Fix command serialization #1013

Closed Levi-Armstrong closed 3 months ago

Levi-Armstrong commented 3 months ago

There are 656 lines of serialization code within tesseract and these two line had the incorrect syntax.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.13%. Comparing base (bd58a0f) to head (aae8125).

:exclamation: Current head aae8125 differs from pull request most recent head 103f5fc

Please upload reports for the commit 103f5fc to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/tesseract-robotics/tesseract/pull/1013/graphs/tree.svg?width=650&height=150&src=pr&token=nh4aHZzgpR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tesseract-robotics)](https://app.codecov.io/gh/tesseract-robotics/tesseract/pull/1013?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tesseract-robotics) ```diff @@ Coverage Diff @@ ## master #1013 +/- ## ========================================== - Coverage 90.13% 90.13% -0.01% ========================================== Files 280 280 Lines 15859 15859 ========================================== - Hits 14295 14294 -1 - Misses 1564 1565 +1 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/tesseract-robotics/tesseract/pull/1013/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tesseract-robotics)
Levi-Armstrong commented 3 months ago

@johnwason Does this fix the issue you were seeing?

johnwason commented 3 months ago

Still seeing the crashes and test failures

Levi-Armstrong commented 3 months ago

Still seeing the crashes and test failures

~Does the example you posted on boost also still fail?~ I see your response on the boost thread so it looks like it is still happening.

johnwason commented 3 months ago

I am looking at this old test case: https://github.com/johnwason/tesseract/actions/runs/8242279639

I need to find the commit locally. I will change the &= to & in this known test case and see if it makes any difference. There are too many changes in master to isolate the problem.

johnwason commented 3 months ago

I didn't realize that some of the &= were in the equals functions... I changed those back and my test case is now failing.