search

tesseract-robotics / tesseract

Motion Planning Environment
http://tesseract-docs.rtfd.io
Other
278 stars 89 forks source link

Fix clang detection on Mac OS #1038

Closed johnwason closed 4 months ago

johnwason commented 4 months ago

Mac OS reports "Clang" as "AppleClang" and wasn't being detected. This PR fixes the compiler detection and a few compiler sign comparison warnings.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.74%. Comparing base (6638c33) to head (9d67963).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/tesseract-robotics/tesseract/pull/1038/graphs/tree.svg?width=650&height=150&src=pr&token=nh4aHZzgpR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tesseract-robotics)](https://app.codecov.io/gh/tesseract-robotics/tesseract/pull/1038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tesseract-robotics) ```diff @@ Coverage Diff @@ ## master #1038 +/- ## ======================================= Coverage 89.74% 89.74% ======================================= Files 283 283 Lines 15958 15958 ======================================= Hits 14321 14321 Misses 1637 1637 ```
johnwason commented 4 months ago

The CI has finished. I need this merged for other PRs.