search

tesseract-robotics / tesseract

Motion Planning Environment
http://tesseract-docs.rtfd.io
Other
259 stars 89 forks source link

Unused includes cleanup #946

Closed rjoomen closed 11 months ago

rjoomen commented 11 months ago

Used clangd to check all files for unused includes

Levi-Armstrong commented 11 months ago

Could we add a CI run which does this check?

rjoomen commented 11 months ago

clang-tidy has misc-include-cleaner, but this is very recent. Our CI has all misc checks already switched on, but the clang-tidy used is too old.

RICB has IWYU functionality, that could be an option. I've tried that once locally, I believe, but could not get it working. Maybe you're able add it to our CI?

Levi-Armstrong commented 11 months ago

Sounds good. Might be easier to try and upgrade clang-tidy at some point.