search

tesseract-robotics / tesseract

Motion Planning Environment
http://tesseract-docs.rtfd.io
Other
275 stars 88 forks source link

Remove use of Industrial CI #961

Closed Levi-Armstrong closed 12 months ago

marip8 commented 12 months ago

Have you thought about turning this into a custom Github action instead? Might be easier to apply to other tesseract repos in future as well

Levi-Armstrong commented 12 months ago

Have you thought about turning this into a custom Github action instead? Might be easier to apply to other tesseract repos in future as well

Yea, that is not a bad idea. Have you ever created one?

marip8 commented 12 months ago

No I haven't, but I don't think it's too difficult. I think it can be as simple as a YAML file defining what steps should run as a part of the custom action and what the input variables can be. You can also have it call custom scripts in the action repo, etc.

marip8 commented 12 months ago

It might make sense to do make a similar custom Github action for building Docker images as well, since the Docker files for tesseract through tesseract_ros2 are not all that dissimilar from one another

codecov[bot] commented 12 months ago

Codecov Report

Merging #961 (aa38bc3) into master (e4a0731) will decrease coverage by 0.87%. The diff coverage is n/a.

:exclamation: Current head aa38bc3 differs from pull request most recent head cd8a7b0. Consider uploading reports for the commit cd8a7b0 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #961      +/-   ##
==========================================
- Coverage   91.78%   90.92%   -0.87%     
==========================================
  Files         243      280      +37     
  Lines       14918    15845     +927     
==========================================
+ Hits        13693    14407     +714     
- Misses       1225     1438     +213

see 523 files with indirect coverage changes