search

tesseract-robotics / tesseract

Motion Planning Environment
http://tesseract-docs.rtfd.io
Other
257 stars 89 forks source link

Add more clone benchmarks #998

Closed Levi-Armstrong closed 5 months ago

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.16%. Comparing base (ea3d5c3) to head (ca24a62).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/tesseract-robotics/tesseract/pull/998/graphs/tree.svg?width=650&height=150&src=pr&token=nh4aHZzgpR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tesseract-robotics)](https://app.codecov.io/gh/tesseract-robotics/tesseract/pull/998?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tesseract-robotics) ```diff @@ Coverage Diff @@ ## master #998 +/- ## ========================================== - Coverage 90.17% 90.16% -0.02% ========================================== Files 280 280 Lines 15701 15701 ========================================== - Hits 14159 14157 -2 - Misses 1542 1544 +2 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/tesseract-robotics/tesseract/pull/998/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tesseract-robotics)
Levi-Armstrong commented 5 months ago

@johnwason Do you know why everything for windows, conda and mac os is failing now? Everything passed in the latest MR that was merged.

johnwason commented 5 months ago

I am not seeing errors locally. I will check on github actions and see if I can capture more data.

johnwason commented 5 months ago

See https://github.com/microsoft/vcpkg/discussions/38140

johnwason commented 5 months ago

Apparently this is a problem with CMake 3.29.1

https://github.com/microsoft/vcpkg/issues/37968

johnwason commented 5 months ago

I am testing adding this step before vcpkg and build steps:

   - name: Setup cmake
      uses: jwlawson/actions-setup-cmake@v2
      with:
        cmake-version: '3.28.x'
johnwason commented 5 months ago

Changing the cmake version worked. https://github.com/johnwason/tesseract/actions/runs/8656859533/job/23738056581

The error is from my artifact capturing, the build did work.

Levi-Armstrong commented 5 months ago

@johnwason Can this also be used to fix the conda builds?

Levi-Armstrong commented 5 months ago

It looks like changing the cmake version fixed the windows builds, but still need to figure out mac and conda build issue.