search

tesseract-robotics / tesseract_ext

This contains external dependencies for Tesseract
1 stars 11 forks source link

Add Google Benchmark #13

Closed mpowelson closed 4 years ago

mpowelson commented 4 years ago

Adds Google Benchmark for benchmarking key functions

gavanderhoorn commented 4 years ago

:+1: for benchmarking, but could this please not be called Benchmark? That's a bit too generic -- and is already colliding with another poorly named package in my workspace ;)

mpowelson commented 4 years ago

Sure. How's google_benchmark?

gavanderhoorn commented 4 years ago

Yes, much better.

Also seems to align somewhat better with REP-144.

Levi-Armstrong commented 4 years ago

I have been using the package name defined in rosdep key so things get built in the correct order. Does a key exist for google benchmark?

gavanderhoorn commented 4 years ago

That would of course always be preferable.

Levi-Armstrong commented 4 years ago

Well it looks like the rosdep key is benchmark shown here. Thoughts?

mpowelson commented 4 years ago

I didn't realize there was a debian. It would seem that we don't need this in that case.

Levi-Armstrong commented 4 years ago

Good point!

gavanderhoorn commented 4 years ago

Wow, what a terrible name for a package.

Leave it to google to claim a regular noun for a C++ library name.

But yeah: if there is a binary and it's recent enough, it should be used.