tesseract-robotics / tesseract_planning

Contains packages related to motion and process planning for the Tesseract Motion Planning Environment
http://tesseract-docs.rtfd.io
Other
46 stars 35 forks source link

Remove `DescartesVertexEvaluator` which duplicates `descartes::StateEvaluator` #476

Open marip8 opened 2 months ago

marip8 commented 2 months ago

The tesseract::DescartesVertexEvaluator is a class that is confusingly similar to the descartes::StateEvaluator and is used to do effectively the same task as the descartes::StateEvaluator but inside the tesseract::DescartesRobotSampler class. This is not really necessary because states will get pruned within the descartes solver itself before edges are added (here fi).

To eliminate this confusion and additional unnecessary class, my suggestion is that we:

Also, we should not be adding arbitrary vertex evaluators to the robot sampler when the user chooses a nullptr for their vertex evaluator selection:

https://github.com/tesseract-robotics/tesseract_planning/blob/fcaf31739f285244b24091f76ee31900c051f081/tesseract_motion_planners/descartes/include/tesseract_motion_planners/descartes/impl/profile/descartes_default_plan_profile.hpp#L205-L219

This should become a non-issue if we remove the class.

Levi-Armstrong commented 2 months ago

I do not have objections to your proposed changes.