search

tesseract-robotics / tesseract_ros2

22 stars 24 forks source link

Changed include paths in utils to reflect the correct paths and replaced SimpleResourceLocator with TesseractSupportResourceLocator. #30

Closed alliethebanana closed 1 year ago

alliethebanana commented 2 years ago

Had opened an issue since I couldn't figure out the solution for this, but by going through the backlog of releases of tesseract I managed to figure that SimpleResourceLocator has been since replaced by TesseractSupportResourceLocator.

This merge request does not cover fixes to the tests folder.

alliethebanana commented 2 years ago

I have also applied fixes to the examples provided, since it seems the methods in the response msg have been changed.

From response.results->as to response.problem->results->as.

Let me know if this is the intended usage.

Levi-Armstrong commented 2 years ago

@GuiAivero if you rebase on this PR will the CI pass? If so,I will merge both.

alliethebanana commented 2 years ago

@GuiAivero if you rebase on this PR will the CI pass? If so,I will merge both.

Done. Fingers crossed that it passes

Briancbn commented 2 years ago

It seems that the .repos files is not updated. CI is still using the 0.7.0 version of tesseract. Changing the dependencies.repos repo versions to match that of ros1 dependencies.rosinstall should fix the foxy CI build. For the format check, add in the suggested changes should pass.

alliethebanana commented 2 years ago

It seems that the .repos files is not updated. CI is still using the 0.7.0 version of tesseract. Changing the dependencies.repos repo versions to match that of ros1 dependencies.rosinstall should fix the foxy CI build. For the format check, add in the suggested changes should pass.

Done! Also added tesseract-qt as a dependency since it was part of the ROS1 dependencies, not sure if it is meant to be included.

Briancbn commented 2 years ago

Please also remember to fix the lint errors reported in the CI as such. https://github.com/Briancbn/tesseract_ros2/pull/2/commits/1136183f239757b6994eef7e5d91595a4e7e6ea0. I can confirm the new CI will pass after the changes https://github.com/Briancbn/tesseract_ros2/runs/7211700850?check_suite_focus=true, the newly added qt package is also causing rosdep dependencies issue. I think should remove for now.

rjoomen commented 1 year ago

I suppose this PR can be closed now, since #35 has been merged.