Closed rjoomen closed 1 year ago
I seems to me that CollisionCoeffData::setPairCollisionMarginData() should be called CollisionCoeffData::setPairCollisionCoeff(), as it sets the coefficient instead of the margin (the getter is correctly called getPairCollisionCoeff()).
Should I submit a PR?
You are correct. Sure please do.
Same file: is this line still correct?
I would say that line can be removed
I removed it at a few more places, please review.
I seems to me that CollisionCoeffData::setPairCollisionMarginData() should be called CollisionCoeffData::setPairCollisionCoeff(), as it sets the coefficient instead of the margin (the getter is correctly called getPairCollisionCoeff()).
Should I submit a PR?