tesseract-robotics / trajopt

Trajectory Optimization Motion Planner for ROS
379 stars 102 forks source link

Naming of CollisionCoeffData::setPairCollisionMarginData() #325

Closed rjoomen closed 1 year ago

rjoomen commented 1 year ago

I seems to me that CollisionCoeffData::setPairCollisionMarginData() should be called CollisionCoeffData::setPairCollisionCoeff(), as it sets the coefficient instead of the margin (the getter is correctly called getPairCollisionCoeff()).

Should I submit a PR?

Levi-Armstrong commented 1 year ago

You are correct. Sure please do.

rjoomen commented 1 year ago

Same file: is this line still correct?

Levi-Armstrong commented 1 year ago

I would say that line can be removed

rjoomen commented 1 year ago

I removed it at a few more places, please review.