tesseract-robotics / trajopt

Trajectory Optimization Motion Planner for ROS
373 stars 101 forks source link

No longer rely on this repos tags to match tesseract tags for docker #396

Closed marrts closed 1 month ago

marrts commented 3 months ago

Per discussion here

marrts commented 3 months ago

The plan will be to continue this forward for each subsequent tesseract repo. So tesseract planning would have the new step like this:

 - name: Set TAG environment variable
        run: |
          # Check if the current workflow run was triggered by a tag.
          if [[ "${{ github.ref_type }}" == "tag" ]]; then
            # If it's a tag event, set the TAG to the latest tagged version of trajopt
            echo "TAG=${{ matrix.distro }}-0.7" >> $GITHUB_ENV
          else
            # If it's not a tag event (e.g., a push to a branch or a PR), set the TAG to distro-master.
            echo "TAG=${{ matrix.distro }}-master" >> $GITHUB_ENV
          fi

And then this would eventually address this issue because we can specify master and don't have to worry about primary branch names matching across repos.

Levi-Armstrong commented 3 months ago

Since tesseract is a dependent I would prefer going forward that this have the same tag as the rest of the tesseract repos for the same reason we decided for those repos.

marrts commented 3 months ago

Since tesseract is a dependent I would prefer going forward that this have the same tag as the rest of the tesseract repos for the same reason we decided for those repos.

Should we also change tesseract_qt main to be master to keep consistency then? And keep main but mark it as deprecated? Then we could simplify this docker tag issue to just match tags all the way through.

Levi-Armstrong commented 3 months ago

That is fine with me.

Levi-Armstrong commented 3 months ago

I renamed tesseract_qt branch