tesseract-robotics / trajopt

Trajectory Optimization Motion Planner for ROS
381 stars 103 forks source link

Add CI for Ubuntu Noble #410

Closed rjoomen closed 1 month ago

Levi-Armstrong commented 2 months ago

It looks like the Noble build is failing because of clang-tidy errors, @rjoomen How do you think we should address this? Currently in Tesseract we run clang-tidy separately to avoid this issue.

rjoomen commented 2 months ago

Not clang-tidy, I think, but gcc, because of the warnings-as-errors option. Or is it the ros-industrial-cmake-boilerplate that runs clang-tidy during a normal build?

rjoomen commented 2 months ago

I can take a shot at fixing all the warnings, as I'm using clangd in VSCode that's fairly easy.

rjoomen commented 2 months ago

See #411.

Levi-Armstrong commented 1 month ago

@rjoomen The MR was merged but there are still errors during the build.

rjoomen commented 1 month ago

Can you merge this, so my next shot at fixing the clang-tidy errors will run the CI I'm trying to pass (I can't merge, because required CI checks do not pass and I do not have enough rights to merge anyway)?

rjoomen commented 1 month ago

See #412.

Levi-Armstrong commented 1 month ago

@rjoomen Still a few clang-tidy errors in trajopt_common/src/utils.cpp.

rjoomen commented 1 month ago

See #414.