Merge rebekah's new banner into main

tessgi / TessGiWebsite

Website for the TESS Guest Investigator Office.

http://tessgi.github.io/TessGiWebsite/

4 stars 5 forks source link

Merge rebekah's new banner into main #46

Closed mrtommyb closed 4 years ago

mrtommyb commented 4 years ago

I think we need to do a little more work on the banner before we merge this

mrtommyb commented 4 years ago

Ok, one last thing. When I make the window really wide, the text on the banner is not all visible

mrtommyb commented 4 years ago

Screenshot from 2020-11-03 16-15-30

mrtommyb commented 4 years ago

Maybe this shouldn't be a blocker on the merge. But I wonder if there is a way to make the image have a max-width?

mrtommyb commented 4 years ago

If we can't get this fixed today, I say we merge and make an issue to fix at a later date.

rebekah9969 commented 4 years ago

I think I fixed the issue with the text - I worry that it may look too small at larger sizes now though. The size of the image seems to increase no matter the fixed width I add.

mrtommyb commented 4 years ago

I'm not sure this fixed it. Did you see the attached image in a previous comment

rebekah9969 commented 4 years ago

Screen Shot 2020-11-04 at 4 02 44 PM I am not sure I see the issue with the title page. I added in a 1vh just in case.

mrtommyb commented 4 years ago

Its definitely still an issue

rebekah9969 commented 4 years ago

This should now be fixed - I had defined one too many vw's in the font-size style. Sorry for the delay

rebekah9969 commented 4 years ago

Do not merge yet as new bug detected doh!

rebekah9969 commented 4 years ago

Bugs all fixed - for now .....

mrtommyb commented 4 years ago

ok, I think we can merge then