tesshucom
commented
5 years ago This Issues was issued after the revised time passed. The fix point is below.
https://github.com/tesshucom/airsonic/commit/cec686cf8a92310a4edce9a6197512e54fb223b1
Since Service refers to personal locale, use LocaleResolver created for this.
ex) before
1)General English, Personal (Default) -> bio = English 2)General English, Personal Japanese -> bio = Japanese 3)General Japanese, Personal (Default) -> bio = English 4)General Japanese, Personal Japanese -> bio = Japanese
after
1)General English, Personal (Default) -> bio = English 2)General English, Personal Japanese -> bio = Japanese 3)General Japanese, Personal (Default) -> bio = Japanese 4)General Japanese, Personal Japanese -> bio = Japanese
3) The case differs. If the user does not do anything with Pesonal, it will take over the value set in General instead of Eng fixed.
Problem description
Request may or may not pass through LocaleResolver. As a result, the setting of Locale intended by User may not be reflected.
Steps to reproduce
For example, Biography of LastFM.
Rest access to LastFM refers only to the language setting of "Personal". Therefore, depending on the setting of "General", even users who are displaying other than English, there is an operation case "Display only in LastFM in English".
This can be avoided by explicitly specifying the locale by "Personal".
Additional notes
Incorporated in Jpsonic.
Japanese people are not good at other than Japanese language and have a strong rejection reaction (· _ ·,) In order to make Japanese understand good software, support of a native language becomes essential.