Implement getStarred2

[tesshucom]

REST considerations. Related airsonic/airsonic#1770, #1752. Prerequisites: v111.6.0

It seems to be one of the things not implemented in Legacy. I don't remember if it was fixed in Jpsonic. There is some ambiguity in ID3 handling, which should be fixed in v111.6.0 or later. (Or they may be fixed at the same time.)

[masterblaster79]

My observation is the following (tested using webui and dsub android client):

• Starring tracks is fine in any case, they are stored in the "starred_media_file" table.
• Starring artists from webui/dsub(folder based) stores the artist folder in "starred_media_file" and is not using the "starred_artist" table
• Starring artist from dsub(tag based), it's stored in the "starred_artist" table
• Starring albums from webui/dsub(folder based) stores the album folder in "starred_media_file" and is not using the "starred_album" table
• Starring albums from API when organizing by tags instead of folders it's stored in the "starred_album" table

So, starring albums/artists is inconsistent whether tag based or folder based browsing is being used.

[tesshucom]

As I remember. . . In the Subsonic API, I think that File Structure and ID3 were defined to use different IDs. (In that sense, I think it was a specification that should be looked at first among many API method specifications.)

The API specification does not define whether tag-based starring and folder-based starring should be correlated. Therefore, I think the implementation specifications are up to each product. I think that Airsonic could not keep up with maintenance on the ID3 side. (Although the definition of the database borrowed a lot from Subsonic.)

What I'm trying to fix is to repair the functionality using the existing table first. Therefore, I think that it is a correction about what you just pointed out.

It's not that difficult, but if e start with something easy, we'll run out of resources. Because there are many similar easy fixes. Core bugs won't be fixed if you get stuck there. That's the wrong path many media servers take. Therefore, although it is decided that it will be fixed, please understand that the timing may be just not now.

The current subject is scan fixes. However, this does not mean that no other amendments will be accepted during that period. If you create a pull request, it would be most welcome.