tesshucom
commented
4 years ago Remove all image tags managed by the theme
All images that can be deleted at this stage have been deleted.
The image of DEPRECATED remains in jpsonic.properties. From here... It's more efficient to clean up the rest of the work by improving the web page.
The target web pages are as follows :
- playQueue.jsp (#640)
- javaJukeboxPlayerControlBar.jspf
- right.jsp
- videoPlayer.jsp
These are screens that require radical refactoring rather than images.
Delete the legacy theme because it has too many disadvantages to deal with the new screen design. Select the previous theme to see what happens if that theme is deleted.
The result of checking:
There seems to be no particular problem. Default is applied if theme does not exist.
However, if the default theme inherits another theme, some properties refer to it. Special handling is required for the theme created by inheriting the conventional default theme. If "Legacy Default Theme" does not exist, there is a possibility that operation will become inoperable due to error in resource acquisition.
[x] Remove all image tags managed by the theme. (#622)
[x] Replace the default theme value in CustomThemeResolver from default to jpsonic
[x] Delete all themes except "Jpsonic Default" and "Jpsonic (embedded JP font)"
[x] Only for the logo used at login page, the URL will be changed so that it is directly described in JSP.