search

tessi / wasmex

Execute WebAssembly from Elixir
MIT License
528 stars 27 forks source link

Rustler 0.30 & latest Elixir/Erlang #511

Closed RoyalIcing closed 4 months ago

RoyalIcing commented 6 months ago

Hey! I saw there’s a new version of Rustler, so here’s an update to it. I believe it’s just a bump with minor changes.

I can make it in a separate PR if you prefer: there’s also updates to Elixir/Erlang so I’ve updated those too.

tessi commented 6 months ago

@RoyalIcing this looks great! thanks for taking care! ❤️

there is just that weird dialyzer error. and just staring at the error output I sometimes wonder if it's worth having it. I cheer for elixirs type system to advance fast :)

RoyalIcing commented 6 months ago

@tessi I'll have a look at the error, I missed that. Yeah I much prefer first-party type systems!

tessi commented 4 months ago

whoar, I guess I'll throw out dialyzer. the benefit it brings doesn't feel big enough compared to the burden of maintenance it introduces.

RoyalIcing commented 4 months ago

whoar, I guess I'll throw out dialyzer. the benefit it brings doesn't feel big enough compared to the burden of maintenance it introduces.

Yeah it only seems to be happening with the latest Elixir? It's not saying which line the problem is coming from so it's difficult to debug. I couldn't see a function matching the erring pattern at first glance.

tessi commented 4 months ago

alright, dialyzer is gone for good. this PR is green. again. Thanks a ton @RoyalIcing 💜