test-fullautomation / RobotFramework_AIO

RobotFramework All in One installer
Apache License 2.0
6 stars 3 forks source link

build::static code analysis per repository #175

Open test-fullautomation opened 1 year ago

test-fullautomation commented 1 year ago

A static code analysis shall be executed per repository.

Code analysis shall be part of pipeline(s).

ngoan1608 commented 8 months ago

Hi Thomas,

Regarding to static code analysis tools, I propose to use:

I have make the initial run (with general configuration) for all related repositories (except document and extensions), results can be found at below url: https://github.com/ngoan1608/RobotFramework_AIO/actions/runs/8016121691/job/21897465613 They are all failed with such below issues:

So we need to define the checker (as configuration for pylint and arguments for cppchecker) for the rules and criteria that we want to check within our project. Please give your idea about this checker first, I will prepare the configuration. Then we should discuss within team meeting to make the decision so that source code on those repo should be updated accordingly.

After that, a job static code analysis will be added as precondition (all checker should be passed) for building AIO. I also think that every repositories need static code analysis job to check any commit from developer (trigger by push on any branch other than develop), so that we can know the static analysis result early and update accordingly.

Please give your idea about my concerns,

Thank you, Ngoan

test-fullautomation commented 5 months ago

Hi @trimai3001 , please also investigate about this issue.

Based on our meeting today my feeling is that we need similar to our test-trigger/-executor a coverage-trigger/-executor and quality-trigger/-executor. This allows us to do a per repository configuration for whatever tool is required.

Thank you, Thomas