search

test-fullautomation / python-jsonpreprocessor

A preprocessor for json files
Apache License 2.0
2 stars 2 forks source link

Fix issue 83, jsonp configuration file path computation. #149

Closed namsonx closed 9 months ago

namsonx commented 9 months ago

Hello Holger,

Thank you for your comments!

Hello Thomas, I have just updated the pull-request.

Thank you, Son

HolQue commented 9 months ago

Hi Son,

what is this:

jFile = CString.NormalizePath(jFile.strip())

?

I already mentioned several times now: NormalizePath does a strip() also. Therefore no need to do this when calling NormalizePath().

Please consider my previous comment:

# at first normalize:
jFile = CString.NormalizePath(jFile) # (NormalizePath does also the jFile.strip() for you ;-)
namsonx commented 9 months ago

Hello Holger,

Sorry for the mistake! I've done it as a habit. I remove .strip()

Thank you, Son

test-fullautomation commented 9 months ago

Hi @namsonx , what is the status of this ticket? Thank you, Thomas