test-fullautomation / robotframework-testsuitesmanagement

Apache License 2.0
4 stars 2 forks source link

Namsonx/task/stabi branch #259

Closed namsonx closed 7 months ago

namsonx commented 7 months ago

Hi Son,

in #238 I mentioned only one single example. Please go through your code and fix all positions with manual line breaks.

Hello Holger,

I updated all newline cases in error message log.

Thank you, Son

HolQue commented 7 months ago

Hi Son,

still line breaks! But they are caused by the JsonPreprocessor now. Probably in lines like;

raise Exception(f"JSON file: {jFile}\n{error}")

Therefore the JsonPreprocessor also needs to be fixed.

For example:

20240318 14:16:18.915 - ERROR - Loading of JSON configuration file failed! 
          Reason: JSON file: D:/ROBFW/Dev/GenSnippetsTSM/tmp_files/config/testconfig.json
Expecting property name enclosed in double quotes: line 15 column 28 (char 398)
20240318 14:16:18.915 - UNKNOWN - Loading of JSON configuration file failed!

This really does not look nice.

test-fullautomation commented 7 months ago

Hi @namsonx , can you please fix the complete line-break issue. Also: can you please update the documentation accordingly. Release_info update is missing, too.

Please also check why the build was failing.

Then I will merge.

Thank you, Thomas

HolQue commented 7 months ago

Hi Son,

please consider also

https://github.com/test-fullautomation/robotframework-testsuitesmanagement/issues/250

for update of history in component documentation.