search

test-fullautomation / robotframework-testsuitesmanagement

Apache License 2.0
4 stars 2 forks source link

Naming convention check (1) #284

Open HolQue opened 4 months ago

HolQue commented 4 months ago

(1)

Input:

"teststring-1"  : "teststring-1 value",
${params.global.teststring-1} : "${params.global.teststring-1} extended"

Result:

ERROR - Found invalid parameter name 'teststring-1'.
UNKNOWN - Violation of naming conventions detected. The test execution will be aborted!

The error detection works fine. But path and name of affected JSON file is missing.

(2)

Input:

"teststring*1"  : "teststring*1 value",
${params.global.teststring*1} : "${params.global.teststring*1} extended"

causes:

ERROR - Invalid parameter format: ${params.global.teststring*1} extended - The double quotes are missing!!!
ERROR - In file: D:/ROBFW/Dev/GenSnippetsTSM/tmp_files/config/testconfig.json
UNKNOWN - Unable to load the test configuration. The test execution will be aborted!

Why this? I would expect a naming convention violation here also. Or '*' is not a forbidden character in names. Then the code should work.

But there are no double quotes missing. Therefore it is not clear to me why the parameter format shall be invalid.

namsonx commented 2 weeks ago

Hello Holger,

After improved naming convention feature, the cases you mentioned in this ticket are acceptable as the comment

Currently, there is no error message for the cases above. Could you please help verify again?

Thank you, Son