Reworked "log level" mechanism

test-fullautomation / robotframework

Generic automation framework for acceptance testing and RPA

http://robotframework.org

Apache License 2.0

1 stars 0 forks source link

Reworked "log level" mechanism #66

Open HolQue opened 4 months ago

HolQue commented 4 months ago

!!! This is for Robot Framework 7.0.1 - and not for our AIO bundle !!!

Reworked "log level" mechanism

new log level 'USER' introduced
amount of output reduced in debug log file and XML report file
self test in robotframework/atest/robot/log_level
documentation in robotframework/atest/robot/log_level/readme_log_level_test.txt

Based on robotframework-7.0.1.dev1-py3.9

"log level" self test extensions

IF condition and FOR loop added to log_level robot file and resource file
added log file comparison for debug log files
pattern files for log file comparison modified
documentation adapted

test-fullautomation commented 3 months ago

Hi @HolQue , very good! did you check and follow the contribution guidelines? https://github.com/robotframework/robotframework/blob/210daa17aeedee53d120d64e0167c03a81edee17/CONTRIBUTING.rst Thank you, Thomas

HolQue commented 3 months ago

Hi @test-fullautomation I tried to adapt the code style of the Robot Framework as far as possible, but these guidelines are new to me. I have to review my code.

W.r.t. https://github.com/test-fullautomation/robotframework/pull/66#discussion_r1511410262

I will remove the CComparison module from the self test. Because this module is part of the PythonExtensioCollection. And this component is not under Robot Framework license. We have to communicate that the self test has a dependency to another component.

test-fullautomation commented 3 months ago

Hi @HolQue ,

I will remove the CComparison module from the self test. Because this module is part of the PythonExtensioCollection. And this component is not under Robot Framework license. We have to communicate that the self test has a dependency to another component.

I think it's not a good idea to create a dependency because of test. Is it not possible to extract only the parts you need for the atest and put this under robot licence?

Thank you, Thomas

HolQue commented 3 months ago

Ach seuftz!

Yes, it's possible. It's also extra effort and unfavorable copy&paste of code. But for sure possible. I understand your motivation.

test-fullautomation commented 3 months ago

very good!

Yes, it's possible. It's also extra effort and unfavorable copy&paste of code. But for sure possible. I understand your motivation.

test-fullautomation commented 3 months ago

Created community pull-request: https://github.com/robotframework/robotframework/pull/5084 To be tracked there.