search

test-fullautomation / robotframework

Generic automation framework for acceptance testing and RPA
http://robotframework.org
Apache License 2.0
1 stars 0 forks source link

-Modified to handle local variable for threading #69

Closed milanac030988 closed 8 months ago

milanac030988 commented 8 months ago

*Fixed issue https://github.com/test-fullautomation/robotframework/issues/50

test-fullautomation commented 8 months ago

Hi @milanac030988 , very good! Can you please also activate the corresponding selftest (I think I implemented this already?) and maintain the release_info file? Thank you, Thomas

HolQue commented 8 months ago

Hi Cuong,

you can activate additional tests (= additional test folders) in the TestTrigger configuration file in this way:

"LOCALCOMMANDLINE" : ["-d \"./atest/aiotestlogfiles\"", "-b aiotestlogfile.log", "-o aiotestlogfile.xml", "\"./atest/robot/log_level\"", "\"./atest/robot/additional_test\""], (additional path in the list)

test-fullautomation commented 8 months ago

Hi Cuong, what Holger writes is also good and meaningful. We would then have the threading selftest in our dashboard. But what I meant is to activate the tests withing the threading.robot file which I commented out due to issues. Thank you, Thomas

milanac030988 commented 8 months ago

Hello Thomas (@test-fullautomation ),

To avoid create too many branches for threading bugs fixing. I created a new branch ugc1hc/feat/develop_6.1_threading_stabilization and then merge all fixed bugs to this branch. At the end, I'll request a pull request from ugc1hc/feat/develop_6.1_threading_stabilization to develop_6.1 branch.

Thanks, Cuong

test-fullautomation commented 7 months ago

Hi @milanac030988 , uups, I overlooked the branch message. Goal was according to our branching strategy for future comunity pull-requests, that all thread releated changes are at one branch (ugc1hc/feat/threading_feature). Can you please bring this change as well as https://github.com/test-fullautomation/robotframework/pull/73 to (ugc1hc/feat/threading_feature), and create a new pull-request? Thank you, Thomas

milanac030988 commented 7 months ago

Hi @milanac030988 , uups, I overlooked the branch message. Goal was according to our branching strategy for future comunity pull-requests, that all thread releated changes are at one branch (ugc1hc/feat/threading_feature). Can you please bring this change as well as #73 to (ugc1hc/feat/threading_feature), and create a new pull-request? Thank you, Thomas

Hi Thomas, I've merge to (ugc1hc/feat/threading_feature) and create pull request https://github.com/test-fullautomation/robotframework/pull/75 Thanks, Cuong

test-fullautomation commented 7 months ago

very good!