test-fullautomation / testresultwebapp

Apache License 2.0
2 stars 1 forks source link

Project, Variant filed too small in db #12

Closed test-fullautomation closed 1 year ago

test-fullautomation commented 1 year ago

Project and Variant field have currently a size of 20 characters.

For the initial need of the WebApp 20 characters was enough, but using e.g. RobotFramework test results the fields are to short.

=> Need to increased to 100 characters.

To be checked if meaningful for other fields, too.

ngoan1608 commented 1 year ago

Hi Thomas,

This issue has been implemented in PR https://github.com/test-fullautomation/testresultwebapp/pull/17

Thank you, Ngoan

test-fullautomation commented 1 year ago

Hi Ngoan, we need here a concept how to handle such project specific changes. This has e.g. impact when we rebase the BVT WebApp... Thank you, Thomas

ngoan1608 commented 1 year ago

Hi Thomas,

I think we can do it by maintaining multiple project specific branches. The common feature can be cherry-picked to all project branches. The project specific feature is only merged to the appropriate project branch.

Thank you, Ngoan

test-fullautomation commented 1 year ago

Hi Ngoan, yes, of course we can make branches, but somehow it makes all again more complex. I started in BIOS already project branches... Let us discuss this in one of our meetings. Thank you, Thomas

test-fullautomation commented 1 year ago

merged and solved with #17