test-go / testify

A toolkit with common assertions and mocks that plays nicely with the standard library
MIT License
24 stars 1 forks source link

Use glide for dependency management #3

Closed hanzei closed 6 years ago

hanzei commented 6 years ago

What does this PR do?

Why is this PR needed?

Since Godep is not longer properly maintained (last commit was about a year ago) I propose to move to glide. It is a well maintained project and wide used.

dignifiedquire commented 6 years ago

I wonder if it would make sense to use https://github.com/golang/dep given that it is on track to become the official dependency tool

philtay commented 6 years ago

dep is the way to go (pun intended...). I was about to open a PR for that but I noticed that we depend on https://github.com/stretchr/objx too. Of course it's not maintained. @dignifiedquire please fork it under this org and tag the last commit as 1.0.0. In this way all of our dependencies will use semver (I've already checked the other two). I'll then open a PR to use dep.

dignifiedquire commented 6 years ago

Fork is done https://github.com/test-go/objx, if you could make a pr to rename things, I'll tag it as v1.0.0

philtay commented 6 years ago

@dignifiedquire done

hanzei commented 6 years ago

Closing this PR in favour of #6