search

test-kitchen / busser-serverspec

A Busser runner plugin for the serverspec testing library
Other
54 stars 41 forks source link

preinstall net-ssh 4.2 since it is the last version that works in rub… #51

Closed grosser closed 5 years ago

grosser commented 6 years ago

…y 2.0/2.1

similar to https://github.com/test-kitchen/busser-serverspec/pull/37

@cl-lab-k @biinari @jorhett @bdeitte

       /opt/chef/embedded/lib/ruby/site_ruby/2.1.0/rubygems/installer.rb:605:in `ensure_required_ruby_version_met': net-ssh requires Ruby version >= 2.2.6. (Gem::InstallError)
        from /opt/chef/embedded/lib/ruby/site_ruby/2.1.0/rubygems/installer.rb:821:in `pre_install_checks'
        from /opt/chef/embedded/lib/ruby/site_ruby/2.1.0/rubygems/installer.rb:279:in `install'
        from /opt/chef/embedded/lib/ruby/site_ruby/2.1.0/rubygems/resolver/specification.rb:97:in `install'
        from /opt/chef/embedded/lib/ruby/site_ruby/2.1.0/rubygems/request_set.rb:166:in `block in install'
        from /opt/chef/embedded/lib/ruby/site_ruby/2.1.0/rubygems/request_set.rb:156:in `each'
        from /opt/chef/embedded/lib/ruby/site_ruby/2.1.0/rubygems/request_set.rb:156:in `install'
        from /opt/chef/embedded/lib/ruby/site_ruby/2.1.0/rubygems/dependency_installer.rb:405:in `install'
        from /tmp/verifier/gems/gems/busser-0.7.1/lib/busser/rubygems.rb:44:in `install_gem'
        from /tmp/verifier/gems/gems/busser-0.7.1/lib/busser/helpers.rb:57:in `install_gem'
        from /tmp/verifier/gems/gems/busser-serverspec-0.5.10/lib/busser/runner_plugin/serverspec.rb:64:in `install_serverspec'
        from /tmp/verifier/gems/gems/busser-serverspec-0.5.10/lib/busser/runner_plugin/serverspec.rb:33:in `test'
cheeseplus commented 5 years ago

Given that 2.1 is woefully end of lifed and unsupported I'm not sure this makes sense to merge.

grosser commented 5 years ago

... by that logic, get rid of < Gem::Version.new('2.0') too :D

cheeseplus commented 5 years ago

Indeed, the existing logic is already dated and should probably die off and by the same token should not be extended any further.

tyler-ball commented 5 years ago

Closing this in favor of https://github.com/test-kitchen/busser-serverspec/pull/59