only store deployment credentials if specified

test-kitchen / kitchen-azurerm

A driver for Test Kitchen that works with Azure Resource Manager

Apache License 2.0

48 stars 52 forks source link

only store deployment credentials if specified #231

Closed jasonwbarnett closed 2 years ago

jasonwbarnett commented 2 years ago

Description

We have a super odd use case where we don't actually want to use the deployment credentials and by adding this flag it gives us the ability to override the deployment creds with the transport credentials provided in a kitchen file.

Issues Resolved

N/A

Check List

[ ] New functionality includes tests
[ ] All tests pass
[ ] PR title is a worthy inclusion in the CHANGELOG

tas50 commented 2 years ago

@jasonwbarnett I assume this will get followed up with a docs PR to the test-kitchen repo?

tas50 commented 2 years ago

Also can you add a spec for this?

jasonwbarnett commented 2 years ago

@tas50 yep. just wanted to ask ya'll if this was something you're open to before completing the PR. Yes to both.

tas50 commented 2 years ago

Seems fine to me

jasonwbarnett commented 2 years ago

@tas50 added docs PR here: https://github.com/test-kitchen/test-kitchen/pull/1871