test-kitchen / kitchen-ec2

A Test Kitchen Driver for Amazon EC2
Other
222 stars 202 forks source link

Improve speed of readiness detection for Windows instances #582

Closed jakauppila closed 2 years ago

jakauppila commented 2 years ago

Move the fetching of the Windows admin password into the wait_until_ready function to speed up readiness detection of Windows instances

Description

In instances where the administrative username/password is not defined by the user, if we change the Windows instance readiness detection to use the retrieval of the admin password as a readiness factor rather than the console output, we can speed up the readiness detection for Windows instances by 4+ minutes.

In my testing:

In contrast to the existing logic:

Issues Resolved

575

Check List

jakauppila commented 2 years ago

This should be good to go now!

@damacus Looks like there's an issue with the yamllint action: https://github.com/actionshub/yamllint/issues/8