search

test-kitchen / kitchen-ec2

A Test Kitchen Driver for Amazon EC2
Other
221 stars 202 forks source link

Support for dedicated hosts #592

Closed thheinen closed 1 year ago

thheinen commented 1 year ago

Description

This implements allocation/deallocation of dedicated hosts.

It also introduces new config options allocate_dedicated_host and deallocate_dedicated_host, which are set to false by default to avoid accidental cost impacts. Also, mac instances will not allow deallocation before 24 hours have passed, so they will (when #591 is implemented) fail if the driver tries automatically deallocating.

Issues Resolved

590

Type of Change

New Feature

Check List

thheinen commented 1 year ago

After documentation got pulled out of the kitchen repositories, can anybody give me a hint on where to add those settings?

Also: those failed unit tests are not related to my code. And two of those look... weird ;-)

ashiqueps commented 1 year ago

Hey @tecracer-theinen,

The documentation was moved to the test-kitchen repo. You can update that at https://github.com/test-kitchen/test-kitchen/blob/main/docs/content/docs/drivers/aws.md and create a separate PR for documentation.

xorima commented 1 year ago

@ashiqueps can we get the contributing guidelines updated to help people discover this docs location?

ashiqueps commented 1 year ago

@Xorima

Sure, I'll update the guidelines.