test-kitchen / kitchen-ec2

A Test Kitchen Driver for Amazon EC2

Other

222 stars 202 forks source link

feat: Implements placement options and license specifications #607

Closed mfortin closed 10 months ago

mfortin commented 11 months ago

Description

Implements placement options and license specifications

Issues Resolved

591

tenancy: dedicated may not be sufficient for all use cases. Adding options to set placement host resource group arn and license configurations may be required in some advanced use cases.

Type of Change

feat: Add placement options and License Specifications

Check List

[x] New functionality includes tests
[ ] All tests pass
[ ] Commit message includes a Conventional Commit Message

damacus commented 10 months ago

Hey @mfortin this looks pretty reasonable to me!

Can you run Chefstyle over the codebase and re-push, please?

mfortin commented 10 months ago

@damacus Done

damacus commented 10 months ago

@mfortin apologies I turned on auto-merge, before we had protected the main branch. Can you repush the PR please?

It looks like there is a problem in the code that the unit tests have picked up.