search

test-kitchen / vmware-vra-gem

A Ruby Gem for interacting with the VMware vRealize Automation system
Apache License 2.0
15 stars 32 forks source link

Make deployment name an optional parameter. #104

Closed Rupesh0688 closed 1 year ago

Rupesh0688 commented 1 year ago

Description

Make deployment name an optional parameter. This allows for automatically defined unique deployment names in API response. While it is recommended that the deployment name be specified, it is not a mandatory parameter. This change will help in the scenario where unique naming convention applies. When the deployment name parameter is not set, the VM is named "deployment + deploymentID".

Check List

Validated change on local setup. Not updating documentation as this is a non-standard scenario.

vkarve-chef commented 1 year ago

@Rupesh0688 thanks for creating the PR. A suggestion, can we make the parameter optional? i.e. it is part of the request payload if non-nil 'name' is supplied and omitted otherwise? This will help folks specify deploymentName when they need to do so via kitchen-vra plugin or another consumer of this gem. cc @ashiqueps

Rupesh0688 commented 1 year ago

I am working on getting the requirement as accordingly