Added the work to turn on and off deep merge

test-kitchen / vmware-vra-gem

A Ruby Gem for interacting with the VMware vRealize Automation system

Apache License 2.0

15 stars 32 forks source link

Added the work to turn on and off deep merge #70

Closed jjasghar closed 5 years ago

jjasghar commented 6 years ago

Put a feature flag in front of deep merge

Signed-off-by: JJ Asghar jj@chef.io

jjasghar commented 6 years ago

https://github.com/chef-partners/kitchen-vra/pull/29 also.

sbrar7 commented 6 years ago

@jjasghar Are there any plans to release this code to enable deep_merge function?

jjasghar commented 6 years ago

@sbrar7 there has been a lot of debate about deep_merge and what it breaks. There were different issues with 7.1 7.2 and 7.3 where i couldn't figure out what was going on.

I'd reach out to @micgo and team to see if they can chime in here. (I don't work on vRA anymore :disappointed: )

stuartpreston commented 5 years ago

I'm closing this PR now as support for the merged/nested/additional parameters has been added via #74