test-kitchen / winrm-transport

WinRM transport logic for re-using remote shells and uploading files
Other
8 stars 9 forks source link

Added tests and fix for non-empty stderr bug - https://github.com/tes… #17

Open rschiefer opened 8 years ago

rschiefer commented 8 years ago

Found this issue after upgrading to PowerShell 5 Production Preview. See related issue - https://github.com/test-kitchen/winrm-transport/issues/14

It looks like this new version of PowerShell 5 adds addition information to the standard error output even when there aren't any errors. This highlighted what I believe is a bug in the parse_response method in the file_transporter. The if condition was checking the raw PowerShell output instead of the "pretty" output.

This is my first Ruby PR so go easy on me. Hope this helps.