search

test-kitchen / winrm-transport

WinRM transport logic for re-using remote shells and uploading files
Other
8 stars 9 forks source link

Fix unpacking process for the compressed folders #4

Closed smurawski closed 9 years ago

smurawski commented 9 years ago

Currently, when files are updated locally and a new kitchen action is taken, the files on the remote node are not updated. This PR changes the unpacking and relocation of the files to make sure that new and updated files are moved into the proper locations.

I've also started adding Pester tests to the supporting PowerShell functions.

smurawski commented 9 years ago

Looks like there are some embedded base64 strings in the tests. I'll have to update those.

tyler-ball commented 9 years ago

I have no idea what I am looking at. @fnichol and @jmundrawala and @adamex?

fnichol commented 9 years ago

@smurawski hopefully #5 (merged) will help with the failure you were seeing today.

smurawski commented 9 years ago

@fnichol @tyler-ball The tests should be fixed, but it should be noted that they are very whitespace dependent.

smurawski commented 9 years ago

The build is failing due to style guidelines. I'll have to poke at it next week.

smurawski commented 9 years ago

@tyler-ball @fnichol Build is good. Quality checks ok as well now.

tyler-ball commented 9 years ago

I'm :+1: but I'm useless for the Powershell. @fnichol and @jdmundrawala?

fnichol commented 9 years ago

@smurawski Aside from potentially deleting a few more bytes in the commented line, I'm :+1: for merge