search

test-kitchen / winrm-transport

WinRM transport logic for re-using remote shells and uploading files
Other
8 stars 9 forks source link

Multiple Updates to WinRM Transport #8

Closed smurawski closed 9 years ago

smurawski commented 9 years ago

Fix unzipping from COM. Closes #7 Fix failed single file copies (when parent directory was not present). Adding more tests around decode_files.ps1 Cleaner error output from @xmik

smurawski commented 9 years ago

@tyler-ball @fnichol These are some pretty necessary updates. I broke COM uploading when I fixed IO.Compression last time. I've got that sorted out and added a bunch of tests around the PowerShell to cover those cases. I've also got the single file copy fail fixed and a test to cover that.

tyler-ball commented 9 years ago

This LGTM, but I could use some help groking the Powershell - @jdmundrawala

jaym commented 9 years ago

@smurawski this fixes the issue i was having You are a god

jaym commented 9 years ago

:100: please :ship:

smurawski commented 9 years ago

@jdmundrawala moving the decode-files call out of the script file makes it easier to test the powershell. Then the script file is just a library of functions and we don't have to try to intercept the invocation to test the internal functions.

tyler-ball commented 9 years ago

We have 2 :+1: - I'm going to merge this unless someone stops me

jaym commented 9 years ago

merge

fnichol commented 9 years ago

I'm seeing pretty decisive :shipit:, so yay!