xmik
commented
9 years ago I am aware of https://github.com/test-kitchen/winrm-transport/pull/4 and changing a way of how decode_files.ps1 is invoked in file_transporter.rb#L254, because, as @smurawski said:
when we ran the Decode-Files line in the script it makes testing a bit tougher
However, that single change fails for me with errors (parsed from CLIXML powershell script output):
>>>>>> ------Exception-------
>>>>>> Class: Kitchen::ActionFailed
>>>>>> Message: Failed to complete #converge action: [[WinRM::Transport::FileTransporter] Upload failed (exitcode: 0), but stderr present
The term 'Function' is not recognized as the name of a cmdlet, function, script
file, or operable program. Check the spelling of the name, or if a path was in
cluded, verify that the path is correct and try again.
At line:3 char:2
+ . <<<< Function Cleanup($o) { if (($o) -and ($o.GetType().GetMethod("Dispose
") -ne $null)) { $o.Dispose() } }
+ CategoryInfo : ObjectNotFound: (Function:String) [], CommandNot
FoundException
+ FullyQualifiedErrorId : CommandNotFoundException
The term 'Cleanup' is not recognized as the name of a cmdlet, function, script
file, or operable program. Check the spelling of the name, or if a path was inc
luded, verify that the path is correct and try again.
At line:32 char:50
+ } catch [exception]{throw $_} finally { Cleanup <<<< $c; Cleanup $in }
+ CategoryInfo : ObjectNotFound: (Cleanup:String) [], CommandNotF
oundException
+ FullyQualifiedErrorId : CommandNotFoundException
The term 'Cleanup' is not recognized as the name of a cmdlet, function, script
file, or operable program. Check the spelling of the name, or if a path was inc
luded, verify that the path is correct and try again.
At line:32 char:62
+ } catch [exception]{throw $_} finally { Cleanup $c; Cleanup <<<< $in }
+ CategoryInfo : ObjectNotFound: (Cleanup:String) [], CommandNotF
oundException
+ FullyQualifiedErrorId : CommandNotFoundException
Remove-Item : Cannot remove item C:\Users\Administrator\AppData\Local\Temp\tmpz
ip-16fce6ee41b3c10b6f4364883253b1a8.zip: The process cannot access the file 'C:
\Users\ADMINI~1\AppData\Local\Temp\tmpzip-16fce6ee41b3c10b6f4364883253b1a8.zip'
because it is being used by another process.
At line:22 char:50
+ if ($tzip) {Unzip-File $tzip $dst;Remove-Item <<<< $tzip -Force}
+ CategoryInfo : WriteError: (C:\Users\ADMINI...4883253b1a8.zip:F
ileInfo) [Remove-Item], IOException
+ FullyQualifiedErrorId : RemoveFileSystemItemIOError,Microsoft.PowerShell
.Commands.RemoveItemCommand
]
>>>>>> ----------------------
>>>>>> Please see .kitchen/logs/kitchen.log for more details
>>>>>> Also try running `kitchen diagnose --all` for configurationThe PowerShell version I tested is:
$PSVersionTable.PSVersion
Major Minor Build Revision
----- ----- ----- -----
2 0 -1 -1
smurawski
fnichol
First commit makes working with powershell scripts outputs easier, does not change any logic, only shows error messages prettier and, in some cases, shows at all (in relation to previous behavior). I really think it should go to master.
Second commit fixes the https://github.com/test-kitchen/test-kitchen/issues/642 issue. Without it, the directory
cookbookswas not unzipped from tmpzip-{hash}.zip file. I tested on Windows 7 only. It may need further testing on other Windows versions.There is still another bug I see, but did not fix: once
dna.jsonandsolo.rbare transferred to Windows vm onkitchen converge, they are not updated on nextkitchen converge. I did not fix it, because it does not bother me and I actually did not go deep through the MD5 functions here.