Prevent NameError on activesupport >= 6.1

[hoshi-sano]

When unexpeced exceptions are raised in test case, ActiveSupport::Testing::Assertions use:

• Minitest::UnexpectedError (AS >= 6.1)
  • https://github.com/rails/rails/blob/v6.1.0/activesupport/lib/active_support/testing/assertions.rb#L36
• tagged_logger (AS >= 7.0)
  • https://github.com/rails/rails/blob/v7.0.0/activesupport/lib/active_support/testing/assertions.rb#L252

---

reproduction code

require "test/unit/active_support"

class TestAssertions < ActiveSupport::TestCase
  test "unexpected error" do
    x = 1
    assert_difference("x") { raise }
  end
end

no require "minitest":

Error: test: unexpected error(TestAssertions): NameError: uninitialized constant ActiveSupport::Testing::Assertions::Minitest
/usr/local/bundle/gems/activesupport-7.0.2.2/lib/active_support/testing/assertions.rb:251:in `rescue in _assert_nothing_raised_or_warn'
/usr/local/bundle/gems/activesupport-7.0.2.2/lib/active_support/testing/assertions.rb:249:in `_assert_nothing_raised_or_warn'
/usr/local/bundle/gems/activesupport-7.0.2.2/lib/active_support/testing/assertions.rb:102:in `assert_difference'
test.rb:7:in `block in <class:TestAssertions>'

no include ActiveSupport::Testing::TaggedLogging:

Error: test: unexpected error(TestAssertions): NameError: undefined local variable or method `tagged_logger' for #<TestAssertions:0x00005641cf790f88 @method_name="test: unexpected error", ...(snip)... >
/usr/local/bundle/gems/activesupport-7.0.2.2/lib/active_support/testing/assertions.rb:252:in `rescue in _assert_nothing_raised_or_warn'
/usr/local/bundle/gems/activesupport-7.0.2.2/lib/active_support/testing/assertions.rb:249:in `_assert_nothing_raised_or_warn'
/usr/local/bundle/gems/activesupport-7.0.2.2/lib/active_support/testing/assertions.rb:102:in `assert_difference'
test.rb:7:in `block in <class:TestAssertions>'

[kou]

Thanks for your report!

But we should not use classes from minitest. I've pushed a fix for this case by using test-unit features directly instead of using classes from minitest.

[hoshi-sano]

I've checked your commits. Thanks for quick response!