Folder structure for discovery rules for multiple patterns

[mal-tee]

The framework seems to support one discovery rule for multiple patterns via the 2nd tuple entry. How should we store this single rule in the current folder structure?

Take PHP pattern 44 for example where the same file exists in three places:

• https://github.com/testable-eu/sast-testability-patterns/blob/d5e4de7e20a55f4ccbfd00988682e6a6cb56bc5e/PHP/44_verify_return_type/1_instance_44_verify_return_type/1_instance_44_verify_return_type.sc
• https://github.com/testable-eu/sast-testability-patterns/blob/d5e4de7e20a55f4ccbfd00988682e6a6cb56bc5e/PHP/44_verify_return_type/44_verify_return_type.sc

• https://github.com/testable-eu/sast-testability-patterns/blob/d5e4de7e20a55f4ccbfd00988682e6a6cb56bc5e/PHP/44_verify_return_type/2_instance_44_verify_return_type/2_instance_44_verify_return_type.sc

  This seems hard to maintain.

[compaluca]

Indeed duplicating the rule is not the best. However for the moment, please follow that practice. We are discussing about removing metadata. If we do so the only possibility is to strictly follow a file structure where each pattern instance comprises its discovery rule.