search

testcontainers / moby-ryuk

Schedule Moby/Docker containers cleanup after specific delay.
https://www.testcontainers.com
MIT License
182 stars 33 forks source link

Publish preview images, add checks for the multi-arch image variants #120

Closed gesellix closed 3 months ago

gesellix commented 6 months ago

Follow up of #110

gesellix commented 6 months ago

As a thought: the workflows introduced here might be re-usable for other repositories in the "testcontainers" organisation. GitHub allows shared workflows. I would like to first copy the workflows from here to one or two other repositories (see the pull request in the helloworld repo), so that we're able to decide whether an abstraction with shared workflows makes sense and how it should look like.

gesellix commented 5 months ago

@mdelapenya did you have a chance to make a final review of the pull request? I would like to take the changes from here to the other pull request in the helloworld repository, so that we can continue working on WCOW support in the testcontainers-java repository.

HofmeisterAn commented 5 months ago

so that we can continue working on WCOW support in the testcontainers-java repository.

FYI @gesellix please be aware of the following limitations: https://github.com/testcontainers/testcontainers-dotnet/issues/1140#issuecomment-2006957120.

gesellix commented 5 months ago

so that we can continue working on WCOW support in the testcontainers-java repository.

FYI @gesellix please be aware of the following limitations: testcontainers/testcontainers-dotnet#1140 (comment).

Thanks for the heads up. I think we can still continue working on WCOW support, because it's an improvement of the status quo without breaking existing use cases. Whether Testcontainers will declare the WCOW support as official or fully supported feature is probably a decision when all the building blocks are in place.

gesellix commented 4 months ago

How and when are we going to continue here? I would like to improve the other tools, for example https://github.com/testcontainers/helloworld/pull/5, aiming at https://github.com/testcontainers/testcontainers-java/pull/8436 to become a step forward. Like already mentioned I would try to have some consistency across the different repositories (trying to minimize maintenance efforts), so this pull request could be a template for other repos. Consolidating them to a shared workflow would come after knowing all required variants.

If this is something you don't want to continue, feel free to leave a note. I guess WCOW support doesn't have a high priority. It would be great, though, if there would be some kind clarity in either working on WCOW support or explicitly not doing it.

mdelapenya commented 3 months ago

@gesellix thanks for your work here, as always. It was delayed for no reason, so please forgive me if it took that long.

mdelapenya commented 3 months ago

@gesellix the diff failed in the merge commit. Could you take a look please?

gesellix commented 3 months ago

@gesellix thanks for your work here, as always. It was delayed for no reason, so please forgive me if it took that long.

No reason to ask for forgiveness, my previous comment might look a bit harsh, but wasn't meant like that. I'm totally aware that maintaining many different projects is a lot of work and that sometimes less important aspects get out of sight :)

gesellix commented 3 months ago

@gesellix the diff failed in the merge commit. Could you take a look please?

Yes, I'll try to investigate asap (this week)!

gesellix commented 3 months ago

@mdelapenya I found two issues, both have been fixed at #130 (see the details over there).