Fix the manifest check - Githubissues

testcontainers / moby-ryuk

Schedule Moby/Docker containers cleanup after specific delay.

https://www.testcontainers.com

MIT License

182 stars 33 forks source link

Fix the manifest check #130

Closed gesellix closed 3 months ago

gesellix commented 3 months ago

This is a follow-up to #120

The manifest now contains entries with "unknown" architecture. The entries aren't relevant to our check on existence of expected "linux" and "windows" entries, so we're simply ignoring "unknown" architectures.
The diff has been fixed to use our input from stdin instead of trying to read any files.

mdelapenya commented 3 months ago

Mmmm failing again: https://github.com/testcontainers/moby-ryuk/actions/runs/9222172622/job/25373416643

@gesellix could you please take a look?

gesellix commented 3 months ago

Yes, will do!

gesellix commented 3 months ago

Oops - my bad: I only fixed the publish workflow, but not the build workflow. I'll create another pull request to fix the build workflow, too. Sorry.

gesellix commented 3 months ago

I'll certainly extract a shared action so that the workflows become easier to maintain. This one and #131 are the best examples to have better abstractions and keeping code DRY 😅

mdelapenya commented 3 months ago

thank you @gesellix! Now the incremental docker images are live https://hub.docker.com/r/testcontainers/ryuk/tags, so we can test them before any release.

Thank you for your hard work!

gesellix commented 3 months ago

That's great! Thanks! 🎉 I"ll continue with the other repositories, stay tuned :)